feat: remove linting rules for composite types by Noroth · Pull Request #2658 · wundergraph/cosmo

Noroth · 2026-03-17T10:47:31Z

This PR removes the linting rules blocking the generation of message types for composite types in the field set of @requires

Summary by CodeRabbit

New Features
- Expose cost controls: @cost and @listsize support across tooling, router, and platform (headers, metrics, and config).
- Add "recompose" operation/CLI to trigger graph recomposition and report composition/deployment results.
Documentation
- New architecture and cost-control docs and examples; docs site page for cost control.
Tests
- Comprehensive tests added for cost and recompose flows.
Refactor
- Removed @requires directive validation feature and related checks; streamlined validation rules.
Chores
- Removed associated validation tests and bumped package versions.

Checklist

I have discussed my proposed changes in an issue and have received approval to proceed.
I have followed the coding standards of the project.
Tests or benchmarks have been added or updated.
Documentation has been updated on https://github.com/wundergraph/docs-website.
I have read the Contributors Guide.

…es-in-protographic

coderabbitai · 2026-03-17T10:47:56Z

Caution

Review failed

Pull request was closed or merged during review

Walkthrough

Removed the @requires directive validation from protographic: deleted the SelectionSetValidationVisitor, removed requires-related imports and logic from sdl-validation-visitor, and deleted corresponding tests. Linting rules were updated to omit the disallowAbstractTypesForRequires rule.

Changes

Cohort / File(s)	Summary
Validation System `protographic/src/sdl-validation-visitor.ts`, `protographic/src/selection-set-validation-visitor.ts`	Removed requires-directive validation: deleted `SelectionSetValidationVisitor`, removed `validateRequiresDirective` and requires-related imports/fields, and removed the `disallowAbstractTypesForRequires` rule from active rules.
Tests `protographic/tests/sdl-validation/01-basic-validation.test.ts`	Removed three tests that asserted errors for invalid `@requires` usage (abstract type in requires, invalid selection syntax, and unclosed brace).

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Possibly related PRs

feat: add support for requires in protographic #2439: Adds the @requires directive validation code (SelectionSetValidationVisitor and requires handling) that this PR removes.
fix: propagate @openfed__requireFetchReasons on Interfaces #2256: Modifies require/requires handling across validation and propagation logic; closely related to removal of requires validation here.
chore: expose schema node in FederationSuccess #2330: Changes federation/subgraph config construction (subgraphConfigBySubgraphName), which may interact with validation shifts that affect federation wiring.

✨ Finishing Touches

📝 Generate docstrings

Create stacked PR
Commit on current branch

codecov · 2026-03-17T10:49:23Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 89.54%. Comparing base (0b76c8c) to head (001e1ac).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files

@@             Coverage Diff             @@
##             main    #2658       +/-   ##
===========================================
+ Coverage   41.37%   89.54%   +48.16%     
===========================================
  Files         783       20      -763     
  Lines      111952     4360   -107592     
  Branches     8573     1199     -7374     
===========================================
- Hits        46325     3904    -42421     
+ Misses      65264      456    -64808     
+ Partials      363        0      -363

Files with missing lines	Coverage Δ
protographic/src/sdl-validation-visitor.ts	`87.05% <100.00%> (ø)`

... and 802 files with indirect coverage changes

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

coderabbitai

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents

Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@protographic/src/sdl-validation-visitor.ts`:
- Line 146: The change removed all `@requires` validation by replacing the
lintingRules array; restore a minimal requires validator rather than dropping it
entirely: ensure this.lintingRules includes a requiresRule (or reintroduce a
requiresRule function) alongside objectTypeRule, listTypeRule, providesRule, and
resolverContextRule, where requiresRule enforces `@requires` syntax and dependency
integrity but does NOT block non-composite types—only remove the
abstract/composite-type restriction within requiresRule's logic so it validates
field presence and correct referenced dependencies without forbidding valid
concrete `@requires` usages.

🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

Push a commit to this branch (recommended)
Create a new PR with the fixes

ℹ️ Review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: f44bc2e6-fcd3-4c3e-8d91-fdeae307c89d

📥 Commits

Reviewing files that changed from the base of the PR and between f24e435 and 6b31cf8.

📒 Files selected for processing (3)

protographic/src/sdl-validation-visitor.ts
protographic/src/selection-set-validation-visitor.ts
protographic/tests/sdl-validation/01-basic-validation.test.ts

💤 Files with no reviewable changes (2)

protographic/tests/sdl-validation/01-basic-validation.test.ts
protographic/src/selection-set-validation-visitor.ts

- wgc@0.111.0 - @wundergraph/cosmo-connect@0.136.0 - controlplane@0.206.0 - @wundergraph/protographic@0.18.1 - @wundergraph/cosmo-shared@0.44.5 - studio@0.161.8

Integrate static and dynamic cost calculation into the router. Expose the static (estimated) cost value in the modules. Expose both costs via telemetry and response headers. Metrics for costs should be enabled individually in the corresponding telemetry section. Composition was reviewed in another PR and merged here. End-to-end benchmark for a big query to measure the impact of cost control: │ SequentialBig │ SequentialBigCostAnalysis │ │ sec/op │ sec/op vs base │ *-14 584.1µ ± 0% 586.7µ ± 0% +0.45% (p=0.000 n=40) │ SequentialBig │ SequentialBigCostAnalysis │ │ B/s │ B/s vs base │ *-14 5.527Mi ± 0% 5.503Mi ± 0% -0.43% (p=0.000 n=40) │ SequentialBig │ SequentialBigCostAnalysis │ │ B/op │ B/op vs base │ *-14 456.1Ki ± 0% 456.1Ki ± 0% ~ (p=0.822 n=40) │ SequentialBig │ SequentialBigCostAnalysis │ │ allocs/op │ allocs/op vs base │ *-14 6.444k ± 0% 6.452k ± 0% +0.12% (p=0.000 n=40) Fixes ENG-8844 Fixes ENG-8986 Co-authored-by: Aenimus <47415099+Aenimus@users.noreply.github.com> Co-authored-by: StarpTech <deusdustin@gmail.com>

- wgc@0.112.0 - @wundergraph/composition@0.54.0 - @wundergraph/cosmo-connect@0.137.0 - controlplane@0.207.0 - @wundergraph/protographic@0.18.2 - router@0.294.0 - @wundergraph/cosmo-shared@0.45.0 - studio@0.161.9

Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>

github-actions · 2026-03-18T09:27:03Z

❌ Internal Query Planner CI failed to run.

…es-in-protographic

Noroth added 3 commits March 16, 2026 14:08

chore: remove obsolete code

04f1ab4

chore: mimimimi

2a8f3ff

Merge branch 'main' into ludwig/eng-8724-add-support-for-abstract-typ…

6b31cf8

…es-in-protographic

Noroth marked this pull request as ready for review March 17, 2026 10:50

Noroth requested review from StarpTech, dkorittki and endigma as code owners March 17, 2026 10:50

coderabbitai Bot reviewed Mar 17, 2026

View reviewed changes

Comment thread protographic/src/sdl-validation-visitor.ts

Aenimus and others added 6 commits March 18, 2026 10:24

feat: add graph recompose (#2652)

5c53eba

chore(release): Publish [skip ci]

2f059f2

- wgc@0.111.0 - @wundergraph/cosmo-connect@0.136.0 - controlplane@0.206.0 - @wundergraph/protographic@0.18.1 - @wundergraph/cosmo-shared@0.44.5 - studio@0.161.8

chore(release): Publish [skip ci]

b9c4bf0

- wgc@0.112.0 - @wundergraph/composition@0.54.0 - @wundergraph/cosmo-connect@0.137.0 - controlplane@0.207.0 - @wundergraph/protographic@0.18.2 - router@0.294.0 - @wundergraph/cosmo-shared@0.45.0 - studio@0.161.9

fix(docs): update version requirements for cost control (#2659)

b06db05

docs(composition): fix README inaccuracies for federateSubgraphs (#2648)

befb299

Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>

Noroth requested review from a team, Aenimus, JivusAyrus, SkArchon, devsergiy, jensneuse, thisisnithin and wilsonrivera as code owners March 18, 2026 09:24

github-actions Bot added studio controlplane cli protocol connect labels Mar 18, 2026

github-actions Bot added router docs-website labels Mar 18, 2026

Merge branch 'main' into ludwig/eng-8724-add-support-for-abstract-typ…

001e1ac

…es-in-protographic

github-actions Bot removed studio controlplane cli protocol connect router docs-website labels Mar 18, 2026

dkorittki approved these changes Mar 18, 2026

View reviewed changes

Noroth merged commit 3426dd3 into main Mar 18, 2026
10 checks passed

Noroth deleted the ludwig/eng-8724-add-support-for-abstract-types-in-protographic branch March 18, 2026 09:37

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: remove linting rules for composite types#2658

feat: remove linting rules for composite types#2658
Noroth merged 10 commits intomainfrom
ludwig/eng-8724-add-support-for-abstract-types-in-protographic

Noroth commented Mar 17, 2026 •

edited by coderabbitai Bot

Loading

Uh oh!

coderabbitai Bot commented Mar 17, 2026 •

edited

Loading

Review failed

Uh oh!

codecov Bot commented Mar 17, 2026 •

edited

Loading

Uh oh!

coderabbitai Bot left a comment

Uh oh!

Uh oh!

github-actions Bot commented Mar 18, 2026 •

edited

Loading

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Conversation

Noroth commented Mar 17, 2026 • edited by coderabbitai Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary by CodeRabbit

Checklist

Uh oh!

coderabbitai Bot commented Mar 17, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Review failed

Walkthrough

Changes

Estimated code review effort

Possibly related PRs

Uh oh!

codecov Bot commented Mar 17, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

coderabbitai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

github-actions Bot commented Mar 18, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Noroth commented Mar 17, 2026 •

edited by coderabbitai Bot

Loading

coderabbitai Bot commented Mar 17, 2026 •

edited

Loading

codecov Bot commented Mar 17, 2026 •

edited

Loading

github-actions Bot commented Mar 18, 2026 •

edited

Loading